[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

bogus change(s) in cl-macs.el



Hello,

There are many changes made in the version 1.46 of cl-macs.el.

revision 1.46
date: 2004/11/16 04:05:29;  author: monnier;  state: Exp;  lines: +219 -225
Use make-symbol rather than gensym.
(loop, cl-parse-loop-clause, defsetf): Use backquote.

First of all, I protest strongly that such a big change has not
been recorded on the ChangeLog file.  Second, the change at least
to the `labels' macro breaks emacs-w3m.  Emacs-w3m uses some cl
macros including `labels' in order to work together with the
external w3m command asynchronously.  The patch below should be
applied.  Third, I'm not sure whether a problem is limited only
to it.

*** cl-macs.el~	Tue Nov 16 21:54:14 2004
--- cl-macs.el	Fri Nov 19 01:30:39 2004
***************
*** 1314,1320 ****
  \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
    (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment))
      (while bindings
!       (let ((var (make-symbol "--cl-var--")))
  	(push var vars)
  	(push (list 'function* (cons 'lambda (cdar bindings))) sets)
  	(push var sets)
--- 1314,1320 ----
  \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
    (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment))
      (while bindings
!       (let ((var (gensym)))
  	(push var vars)
  	(push (list 'function* (cons 'lambda (cdar bindings))) sets)
  	(push var sets)

Regards,