[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: Menu bar pushed to right on MacOS

on Wed Mar 18 2009, Katsumi Yamaoka <yamaoka-AT-jpl.org> wrote:

>>>>>> In [emacs-w3m : No.10783]
>>>>>>	David Abrahams <dave@xxxxxxxxxxxx> wrote:
>> I have more info on this bug.  It is at least partially fixed or worked
>> around by the enclosed patch.  I'm not sure if this is the right fix
>> overall, as I can't imagine why one wouldn't want this menu to have a
>> title in emacs >= 23.  I also don't know that I'm checking exactly the
>> right condition here.  All I can tell you is that "it works for me" (so
>> far).
>> --- w3m.el.~1.1422.~	2009-02-25 15:23:56.000000000 -0500
>> +++ w3m.el	2009-03-18 14:29:17.000000000 -0400
>> @@ -7953,7 +7953,8 @@
>>  (easy-menu-define w3m-link-menu w3m-link-map "w3m link menu."
>>    `(,(if (or (featurep 'xemacs)
>> -	     (< emacs-major-version 22))
>> +	     (memq system-type '(darwin macos))
>> +             (< emacs-major-version 22))
>>  	 "Link")
>>      [,(w3m-make-menu-item "リンクをこのセッションで開く"
>>  			  "Open Link in This Session")
>> HTH,
> Thank you very much for investigating the bug.  Yes, it's a bug,
> I believe.  What I did there was to suppress the menu title, since
> I felt it's useless.  

At least on MacOS, with no title, it's impossible to tell there's a menu
there at all unless you look really closely.  I am also a Linux user and
though I haven't checked it, I'd be surprised if the effect under Gnome
was not similar.

> Though it was not fulfilled in Emacs 21 and XEmacs.  Moreover, it
> didn't occur to me to consider what it does in the platforms other
> than Linux.  The title string is passed to `x-popup-menu' (at least in
> Linux) that is a built-in function designed according to the system.
> Maybe the MacOS version does not allow the nil value for it.
> I've fixed it in CVS so that it always provides the title string.


Dave Abrahams
BoostPro Computing