[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: w3m-content-type-alist default text/html handler

Johan Claesson <johanclaesson@xxxxxxxxxxxx> wrote:
> Hi,

> The default value for text/html handler in the w3m-content-type-alist
> is based among other things on the variable
> browse-url-browser-function.  It works as expected when
> browse-url-browser-function is set to a symbol like
> browse-url-firefox.  But this variable can also have a alist value,
> for example like this:

> (setq browse-url-browser-function '(("^mailto:" . browse-url-mail)
>      				    ("." . browse-url-firefox)))

> In this case the text/html handler will not get a appropriate value.
> This will make the command w3m-view-url-with-external-browser (bound
> to M) download the webpage instead of browsing it in a external
> browser.

> The following patch of w3m.el attempts to remedy this.  It will walk
> through the alist and select whatever entry that matches the url
> index.html.

Thanks!  Could you eliminate a cl macro in it?  Normally the use
of cl macros is ok, but they have to be expanded at the compile
time since emacs-w3m never uses cl at run-time, like the rest.
However, macros will not be expanded in defcustom forms, except
for the recent XEmacs 21.5.  So, an alist value for
`browse-url-browser-function' will cause the `(void-function loop)'

In addition, please provide a chengelog entry by yourself.