Re: [PATCH] Add functionality for editing textareas in Org-mode

[Thorsten Jolitz <tjolitz@xxxxxxxxx>]

Katsumi Yamaoka <yamaoka@xxxxxxx> writes:

> In [emacs-w3m : No.12161] Thorsten Jolitz wrote:
>> here is patch for my last patch that fixes the conditional activation of
>> keymaps for w3m-form-input-textarea-mode (thx to Stefan Monnier for his
>> help on this).
>
> Sorry for the delay.  Though I haven't yet looked into your version
> throughly, it looks incomplete.
>
> $ emacs -q -batch -l ./w3m-form.el
> Symbol's value as variable is void: w3m-form-input-textarea-map

Ups, I mispelled this one (-> w3m-form-input-textarea-mode-map)

> How does `w3m-form-input-textarea-map' inherit
> `w3m-form-input-textarea-mode-map' or
> `w3m-form-input-textarea-org-mode-map'?  Otherwise, did you mean
> to rename `w3m-form-input-textarea-map' into those keymaps?

No, the renaming was accidental. I added
`w3m-form-input-textarea-org-mode-map' and arranged things that it is
used instead of default `w3m-form-input-textarea-map' when major-mode in
the textarea edit buffer is 'org-mode.

> Anyway you must try running at least `./configure; make install'
> before posting patches.  

mmhh, did not work somehow, but starting emacs-w3m and then loading
modified w3m-form.el again had me edit textareas in an Org-mode edit
buffer without problems, so I hope it works now.

> In addition, please provide the ChangeLog entry by yourself.

Done.

PS 
find attached the new patches

From 256828fc33be0583023717302c43944f21058580 Mon Sep 17 00:00:00 2001
From: tj <tj@xxxxxxxxxxxxxx>
Date: Mon, 7 Oct 2013 09:36:49 +0200
Subject: [PATCH 3/4] misnamed w3m-form-input-texarea-mode-map fixed ("-mode"
 deleted)

---
 w3m-form.el | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/w3m-form.el b/w3m-form.el
index ca79be1..dcec229 100644
--- a/w3m-form.el
+++ b/w3m-form.el
@@ -1121,16 +1121,16 @@ character."
 	    lines
 	    (get-text-property (point) 'w3m-form-readonly)))))
 
-(defvar w3m-form-input-textarea-mode-map nil)
-(unless w3m-form-input-textarea-mode-map
-  (setq w3m-form-input-textarea-mode-map (make-sparse-keymap))
-  (define-key w3m-form-input-textarea-mode-map "\C-c\C-c"
+(defvar w3m-form-input-textarea-map nil)
+(unless w3m-form-input-textarea-map
+  (setq w3m-form-input-textarea-map (make-sparse-keymap))
+  (define-key w3m-form-input-textarea-map "\C-c\C-c"
     'w3m-form-input-textarea-set)
-  (define-key w3m-form-input-textarea-mode-map "\C-c\C-q"
+  (define-key w3m-form-input-textarea-map "\C-c\C-q"
     'w3m-form-input-textarea-exit)
-  (define-key w3m-form-input-textarea-mode-map "\C-c\C-k"
+  (define-key w3m-form-input-textarea-map "\C-c\C-k"
     'w3m-form-input-textarea-exit)
-  (define-key w3m-form-input-textarea-mode-map "\C-c\C-s"
+  (define-key w3m-form-input-textarea-map "\C-c\C-s"
     'w3m-form-input-textarea-save))
 
 (defvar w3m-form-input-textarea-org-mode-map nil)
-- 
1.8.2.3

Attachment: 0004-New-ChangeLog-entry-by-Thorsten-Jolitz.patch
Description: new-changelog-entry

-- 
cheers,
Thorsten