[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [PATCH] w3m-filter: correct return value, remove extra code



On 2017-06-12 11:35, Katsumi Yamaoka wrote:
> In [emacs-w3m : No.12675]
> On Mon, 12 Jun 2017 10:06:09 +0900, Katsumi Yamaoka wrote:

> Well, is there a way to get rid of those compiler warnings against
> `w3m-filter-delete-regions' and `w3m-filter-replace-regexp'
> exclusively?

My first guess, because of the number of times the warnings are
issued, is that those errors are because the functions are now macros.
It's a bit late for me to continue on this - I was planning on
stopping now, but I can check tomorrow or next by reverting them to a
function or trying another way to have it always return a correct
return value.

Today has otherwise been a productive session on the project. I've
updated the two site filters site filters that I submitted last week,
to cover the home and index pages of the sites, to make them look
better, and to add som functionality. For orderliness sake, I'll send
them in a separate e-mail now.

>
> Compiling w3m-filter.el...
>
> In w3m-filter-rt:
> w3m-filter.el:803:23:Warning: value returned from (> i 0) is unused
>
> In w3m-filter-slashdot:
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> w3m-filter.el:808:29:Warning: value returned from (> i 0) is unused
> Wrote w3m-filter.elc
>

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0