[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [PATCH] Added w3m-external-view-temp-directory for external viewer files

In [emacs-w3m : No.12708]
On Thu, 22 Jun 2017 16:43:53 -0700, Vladimir Sedach wrote:
> Attached is a patch that adds a new variable,
> w3m-external-view-temp-directory, that can be used to specify where
> w3m-external-view puts temporary files.

Applied.  Thanks.

> +(defcustom w3m-external-view-temp-directory
> +  w3m-profile-directory
> +  "*Directory where files are saved for the external file viewer."
> +  :group 'w3m
> +  :type '(directory :size 0))

I removed "*" and the `:size 0' portion.  Though I don't recall
clearly why I added `:size 0' to defcustoms in the past, it
might have been useful for old Emacsen (or XEmacs?; I used to be
an XEmacs user).  However, I find no particular advantage with
it now.  If anything, this makes a user be hard to find the
place of the input form if the value is an empty string.  So,
I'd like to remove all such ones some day.