[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: scrolling multiple lines [PATCH INCLUDED]

In [emacs-w3m:12779]
On Thu, 03 Aug 2017 19:05:33 -0400, Boruch Baum wrote:
> I was surprised just now to notice that emacs-w3m does not allow me to
> use a prefix argument to scroll more than one line at a time, ie.
>   C-u M-x w3m-scroll-up
>   C-u M-x w3m-scroll-down

Oh, I've never been noticing it.  Thank you for fixing the bugs.
Committed.  But I've replaced

> +(defun w3m-scroll-down (&optional arg)
> +  "Scroll the current window down ARG lines."
> +  (interactive "P") (scroll-up (if arg arg 1)))

`scroll-up' with `scroll-down'. ;-)


> In emacs25, when I modified the functions to accept prefix arguments,
> I saw no untowards effects when "`scroll-margin' is set as two or
> greater.", so if that's the case also with emacs24 (and emacs23 ?),
> how about removing that restriction?

> You'll note that the attached proposed patch also removes all special
> treatment for existence of a mouse-wheel scroll. When I connected a
> mouse, I found that scrolling was much choppier and less reliable than
> with a keyboard, and was often subject to a delay. Removing the code
> per the patch changed nothing, ie. mouse-wheel scrolling still worked,
> and with the same limitations as before.

I believe no one will be troubled with an Emacs 21 bug nowadays.