[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: w3m-session retain cursor positions [PATCH]

In [emacs-w3m:12832]
On Thu, 07 Dec 2017 00:29:56 -0500, Boruch Baum wrote:
> Within the session-session minibuffer (M-x w3m-session-select, bound by
> default to M-s), when one performs a rename or a delete, the cursor
> (point) would jump to the first entry of the minibuffer.

> This patch fixes that.

> Also, while I was 'in the neighborhood', I performed edits on some of
> the code to (hopefully) simplify / clean-up. In my testing, it doesn't
> seem to have introduced any trouble.

> Two of the notable cleanups were: an unnecessary throw/catch idiom; and
> a deprecated use of an argument in a read function.

> For your consideration ...

Thanks.  I've installed your patch with a slight modification.

>  (defun w3m-session-delete (sessions num)
> -  (let (tmp)

Because this deletion caused these warnings:

In w3m-session-delete:
w3m-session.el:752:15:Warning: assignment to free variable `tmp'
w3m-session.el:753:11:Warning: reference to free variable `tmp'