[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: Fixing session management for individual buffers [PATCH]

In [emacs-w3m:12907]
On Thu, 15 Feb 2018 23:29:53 -0500, Boruch Baum wrote:
> This has been a long time coming, and I hope I got it all okay. Please
> triple-check the work.

> Before trying the patch, observe the current behavior by performing
> the following: exit emacs-w3m, back up your .sessions file (by default
> stored in ~/.w3m/.sessions, delete the original, start emacs-w3m, open
> a single url, save the session (M-S) as "test1", open a second url,
> save the session (M-S) as "test2", open a few more urls, and save the
> session a few more times. All this in order to give you material to
> play with.

> Now let's observe some of the current problems. Enter session
> management (M-s) and view all your sessions. Navigate to one of larger
> ones, and press (M-s) again to view the detailed list of all that
> session's buffers (tabs). Rename and delete a few. Exit back to the
> parent list of sessions by pressing `q' or C-g'.

> The attached patch should make that all work (please, G-d). It seems
> to be reliably working for me at this point.

> The patch also corrects grammar in some of the prompts, and adds some
> documentation.

I've installed your patch as is (before trying the new features).
Thank you.

But please consider Emacs' convention about doc string:
(info "elisp(Documentation Tips)") <- type `C-x C-e' here.
| • The first line of the documentation string should consist of one or
|   two complete sentences that stand on their own as a summary.  ‘M-x
|   apropos’ displays just the first line, and if that line’s contents
|   don’t stand on their own, the result looks bad.