[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [emacs-w3m/emacs-w3m] New feature: copy links to OS clipboard (#12)

This is a feature that I find very useful and convenient, and I have been using a defadvice version of it for a few years.

However, as a pull request, the commit has two serious flaws that I need help with:

  1. The defcustom is flawed, in that it incorrectly says that the car of each cons cell in the list is the first radio button (no matter what that radio button is). I haven't figured out how to have customize variable properly read the current setting. My suspicion is that I need to write a :set, :get, or :initialize function, but I'm not sure which or how, and my attempts were unsuccessful and frustrating.

  2. The list of command strings for the various operating systems only has an entry for linux, and it should have entries for all the major operating systems on which emacs is deployed. I'm the wrong guy for that, because I only use linux, I have no idea how things are done in those other environments, and even if I found command strings, I have no way to test them.

SUMMARY: If you use linux, and you don't use customize-variable, this pull-request is great and complete!

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.