Re: A small hack and a patch

[Katsumi Yamaoka <yamaoka@xxxxxxx>]

Hi,

I'm sorry for the late reply.

>>>>> In [emacs-w3m : No.05683]
>>>>>	myrkraverk@users.sourceforge.net wrote:

> Hi,

> I made this small hack (and here is a patch) so that w3m-view-this-url
> does not switch buffers for me.  I use escreen and want to swith
> buffers myself.

> I hope this is not too crude, it's a recent version from cvs to w3m.el

Thank you for pointing the problem.  That feature is for the use
of Emacs in the terminal emulator.  Emacs-w3m used to not make
the new buffer visible when a user followed a link which points
to a local file, refers to a mailto url, etc.  Is escreen
helpful also for that situation?  In other words, can escreen
users notice the new buffer created by emacs-w3m enters the
Emacs session?  Although I tried escreen a little, I couldn't
know how do I do for that.

> +(defcustom w3m-do-not-switch-buffers-when-doing-w3m-view-this-url nil

The naming is bad.  It is meaningless for ordinary users, isn't
it?

> -	(unless (eq buffer newbuffer)
> +	(unless (or
> +		 w3m-do-not-switch-buffers-when-doing-w3m-view-this-url
> +		 (eq buffer newbuffer))

Well, can't it be replaced with window-system, (featurep 'escreen),
and so forth?  I think it is better to automate if possible.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>