[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
no-defsubst (was Re: recentre anchor at top of window)
- From: Katsumi Yamaoka <yamaoka@xxxxxxx>
- Date: Tue, 28 Apr 2009 19:28:52 +0900
- X-ml-name: emacs-w3m
- X-mail-count: 10860
- References: <87vdp2rhef.fsf@xxxxxxxxx> <b4mbpqro832.fsf@xxxxxxx> <87r5zft2cn.fsf@xxxxxxxxx> <b4mzle2o65q.fsf@xxxxxxx>
>>>>> In [emacs-w3m : No.10855] Katsumi Yamaoka wrote:
(B>>>>>> In [emacs-w3m : No.10853] Kevin Ryde wrote:
(B>> Katsumi Yamaoka <yamaoka@xxxxxxx> writes:
(B>>> `w3m-view-this-url-1' is an inline function.
(B>> Incidentally, is that defsubst a leftover from when that function was
(B>> only used once, as more of w3m-view-this-url, or something? If it's now
(B>> used in four places perhaps it shouldn't be inlined.
(B> Not only it, there are some other inline functions that don't
(B> seem to have to be inlined. I think it's not worth inlining at
(B> least large ones like `w3m-toggle-inline-images-internal' and
(B> `w3m-view-this-url-1'. They only fatten the elc file.
(BI've made the `no-defsubst' branch in the emacs-w3m CVS repository.
(BThere most of inline functions have been changed into the ordinary
(Bones (i.e., using `defun', not `defsubst'). I think the overhead
(Bof funcall is not dominant in time those functions take. I'll try
(Busing it for a while. Developers who have an interest in it, you
(Bcan checkout that branch as follows:
(B$ cvs -d xxxxxxxx co -r no-defsubst emacs-w3m
(BP.S. I've made mistakenly the `no-defsubst-' branch. Sorry.
(BTsuchiya-san, could you please remove it?
$B4X?t$rIaDL$N$b$N$KJQ$($F$"$j$^$9(B ($B$D$^$j(B `defsubst' $B$G$O$J$/$F(B
$BDI?-(B: $B4V0c$C$F(B `no-defsubst-' $B$H$$$&;^$r:n$C$F$7$^$$$^$7$?!#$9$_(B