[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [21.5] bytecomp bug
- From: Aidan Kehoe <kehoea@xxxxxxxxxxxxx>
- Date: Tue, 13 Dec 2011 20:54:31 +0000
- X-ml-name: emacs-w3m
- X-mail-count: 11699
- References: <b4m39cwcwrj.fsf@xxxxxxx> <20192.35656.646615.622693@xxxxxxxxxxxxx> <b4m4nxbxs7q.fsf@xxxxxxx>
Ar an t-ochtú lá de mí na Nollaig, scríobh Katsumi Yamaoka:
> Aidan Kehoe <kehoea@xxxxxxxxxxxxx> wrote:
> > Ar an seachtú lá de mí na Nollaig, scríobh Katsumi Yamaoka:
> >> The combination of the `lexical-let' macro and the `labels' macro
> >> produces the `(quote lambda)' element in its expanded form as
> >> the case may be, and the most recent bytecomp got to fail with it.
> > Thanks for the clear and detailed bug report. This is my bug, I ll commit a
> > fix within a next week.
> Thanks. Good luck on you!
I’ve just committed:
which addresses the problem you reported. I’ve also committed:
which addresses a separate problem that I need to fix in order to get
emacs-w3m to compile (fair enough, glad to have the opportunity to fix it).
I, however, also need the following change to W3M to get it to compile, I’m
surprised you’re not seeing it (the problem was an interaction of
lexical-let and compile-time defsetf expansion).
RCS file: /storage/cvsroot/emacs-w3m/w3m.el,v
retrieving revision 1.1545
diff -u -r1.1545 w3m.el
--- w3m.el 7 Dec 2011 02:35:46 -0000 1.1545
+++ w3m.el 13 Dec 2011 20:50:51 -0000
@@ -2873,8 +2873,8 @@
Otherwise return nil."
(let ((v (w3m-arrived-intern url t)))
(and v (boundp v) (symbol-value v))))
-(defsetf w3m-arrived-time (url) (value)
- (list 'w3m-arrived-add url nil nil value))
+(defsetf w3m-arrived-time (url-) (value)
+ (list 'w3m-arrived-add url- nil nil value))
(defun w3m-arrived-put (url property value)
"Store VALUE in the arrived URLs database as the PROPERTY of URL.
‘Iodine deficiency was endemic in parts of the UK until, through what has been
described as “an unplanned and accidental public health triumph”, iodine was
added to cattle feed to improve milk production in the 1930s.’
(EN Pearce, Lancet, June 2011)