[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: Bug: `a' broken in emacs-snapshot



In [emacs-w3m : No.11919] Michael Heerdegen wrote:
> In Debian, I use the w3m-el-snapshot and emacs-snapshot packages.

> If I hit `a' in w3m, I get the following error:

> Debugger entered--Lisp error: (error "Invalid time specification")
>   set-visited-file-modtime(0)
>   w3m-bookmark-buffer()
>   w3m-bookmark-sections()
>   w3m-bookmark-add("http://emacs-w3m.namazu.org/"; "Text browser works on Emacs")
>   w3m-bookmark-add-current-url(nil)
>   call-interactively(w3m-bookmark-add-current-url nil nil)

> Dunno since when this happens.  I think that they just changed
> `set-visited-file-modtime' so that just 0 is not accepted anymore.
> FWIW, due to the doc of `set-visited-file-modtime', the argument must be
> of the form (HIGH LOW USEC PSEC) as returned by `current-time'.

Thanks for this.  We who already have a bookmark file will have
had no chance to know it.  Fixed in emacs-w3m CVS as follows:

2012-10-10  Katsumi Yamaoka  <yamaoka@xxxxxxx>

	* w3m-bookmark.el (w3m-bookmark-buffer): Use (0 0) as the Unix epoch.

--- w3m-bookmark.el~	2012-07-18 06:03:30.117297300 +0000
+++ w3m-bookmark.el	2012-10-10 22:44:59.501296100 +0000
@@ -179,5 +179,3 @@
 					;; No bookmark file.
-					(with-temp-buffer
-					  ;; 0 in Emacs; (0 . 0) in XEmacs
-					  (visited-file-modtime))))
+					'(0 0)))
 	  (buffer-enable-undo))