[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

[PATCH] RT reply form submission (Emacs-w3m bug)



Hello Emacs-w3m users and developers!

Just found a bug in Emacs-w3m that prevented me from submitting
replies when using the web interface of the RT[0].  I haven't dived
into the code to track down the actual cause of the bug yet, but the
attached patch solves the issue, demonstrably without any possibility
of regressions.

Thanks for maintaining such amazing software!


Footnotes:

[0] https://bestpractical.com/rt/

-- 
 88888  FFFFF Bruno FĂ©lix Rezende Ribeiro (oitofelix) [0x28D618AF]
 8   8  F     http://oitofelix.freeshell.org/
 88888  FFFF  mailto:oitofelix@xxxxxxx
 8   8  F     irc://chat.freenode.org/oitofelix
 88888  F     xmpp://oitofelix@xxxxxxxxxx

- GNU ccd2cue maintainer
- GNU Savannah hacker
- GNU webmaster
- GNU web translation team coordinator (Brazilian Portuguese)
- GNU audio and video maintainer
- DMOZ free software editor (Portuguese)
- UFU FAMAT PET member
- SDF Public Access UNIX System ARPA member
- Riseup user and supporter

Please, support my work: http://oitofelix.freeshell.org/funding.html

[GNU DISCLAIMER] I'm a GNU hacker, but my views don't necessarily
match those of the GNU project.  Hereby I express my own opinion,
style and perception, in good faith, aiming the betterment of GNU.
--- w3m-form.el~	2015-10-09 18:32:44.016715939 -0300
+++ w3m-form.el	2015-10-09 19:13:23.329530878 -0300
@@ -354,7 +354,8 @@
 			   "Content-Disposition: form-data; name=\""
 			   (car buf)
 			   "\"\r\n\r\n"
-			   (encode-coding-string (cdr buf) coding)
+			   (encode-coding-string
+                            (if (cdr buf) (cdr buf) "") coding)
 			   "\r\n"))
 		 (setq bufs (cdr bufs)))
 	       (insert "--" boundary "--\r\n")

Attachment: pgpFQDA3R464h.pgp
Description: Assinatura digital OpenPGP