[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [PATCH] RT reply form submission (Emacs-w3m bug)

In [emacs-w3m : No.12517]
	On Fri, 09 Oct 2015 19:31:49 -0300, Bruno Félix Rezende Ribeiro wrote:
> Just found a bug in Emacs-w3m that prevented me from submitting
> replies when using the web interface of the RT[0].  I haven't dived
> into the code to track down the actual cause of the bug yet, but the
> attached patch solves the issue, demonstrably without any possibility
> of regressions.

Sorry, I see no difference in <https://bestpractical.com/rt/>
between unpatched and patched w3m-form.el.  But everytime I see
the error message "Cannot retrieve URL:..." in the beginning of
a page.  It is because the gzipped data emacs-w3m receives from
the server are somewhat corrupted; `gzip -d' says "unexpected
end of file".  Maybe there is something wrong in emacs-w3m or
w3m (Firefox works fine with no error).

Anyway, does your patch really help you to work there?  If so,
I'll apply your patch to emacs-w3m since what it does is

> -   (encode-coding-string (cdr buf) coding)
> +   (encode-coding-string
> +     (if (cdr buf) (cdr buf) "") coding)

But it would be better to be:

      (if (cdr buf)
	  (encode-coding-string (cdr buf) coding)