[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: face-spec window-system definition for tty's

In [emacs-w3m:12788]
On Fri, 11 Aug 2017 03:10:28 -0400, Boruch Baum wrote:
> There are faces that seem to be using a deprecated version of the face
> spec definition. At this point, it doesn't seem to cause trouble, but it
> might be prudent to patch before it does.

> The face spec can include a list of conditions for when to apply a face
> based upon its DISPLAY characteristics. One of those conditions is the
> DISPLAY 'type', meaning whether it is a character-only tty or one form
> of (window-system). I don't know the emacs history for the list of valid
> options, but the current (v25.2) documentation says that tty's should be
> listed as `nil', not tty.

> As an aside, the reason I came across this was that I use emacs-w3m in a
> tty and have become annoyed that face w3m-italic was displaying as
> underlined, as opposed to maybe bold. Anyone else share that annoyance
> at the default? For me, the fix was to add to my personal
> `my-w3m-mode-hook' function the line:

>  #+BEGIN_SRC emacs-lisp
>  (face-spec-set 'w3m-italic '((((type nil)) (:underline nil :bold t))))
>  #+END_SRC

Thank you for the patch.  I've applied it in CVS.