Re: w3m-session retain cursor positions [PATCH]

[Boruch Baum <boruch_baum@xxxxxxx>]

On 2017-12-07 01:55, Boruch Baum wrote:
> On 2017-12-07 15:37, Katsumi Yamaoka wrote:
> > In [emacs-w3m:12832]
> > Thanks.  I've installed your patch with a slight modification.
> >
> > >  (defun w3m-session-delete (sessions num)
> > > -  (let (tmp)
> >
> > Because this deletion caused these warnings:
> >
> > In w3m-session-delete:
> > w3m-session.el:752:15:Warning: assignment to free variable `tmp'
> > w3m-session.el:753:11:Warning: reference to free variable `tmp'
> >
>
> Oops, I forgot to test by byte-compiling. I meant for that line to be
> deleted because the definition of tmp was supposed to be included in
> "the other `let'", like this:
>
> (defun w3m-session-delete (sessions num)
>   (if (consp num)
>     (let ((item (nth 2 (nth (car num) sessions))) tmp)
>

Better:

(defun w3m-session-delete (sessions num)
  (if (consp num)
    (let* ((item (nth 2 (nth (car num) sessions)))
           (tmp (delete (nth (cdr num) item) item)))



-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0