[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: w3m-search feedback for whether in new or current session [PATCH]

Your patch has been applied.  Thanks.

In [emacs-w3m:12837]
On Thu, 07 Dec 2017 06:32:53 -0500, Boruch Baum wrote:
> 1] Default key-bindings:

> The project doesn't by default bind a key to `w3m-search-new-session',
> though I would think that would be a very desirable function. I wanted
> to propose binding it to 's', but that binding is already used for
> `w3m-history' (in my personal opinion and personal experience, rarely
> used).

> What I've done on my personal system and what I propose, is to map 's'
> to `w3m-search', and 'S' to `w3m-search-new-session'. The result is that
> there is a parallel between the two search functions (s,S) the two go-to
> functions (g,G), the two bookmark functions (v,V), and possibly others.
> The loser would be `w3m-history'.

Sounds good to me.  I rarely use `w3m-history' as well.  So, er,
is it ok to rebind `w3m-history' to M-h (i.e., ALT-h or ESC h)?
In addition, we have two keymap sets `w3m-lynx-like-map'
(the default) and `w3m-info-like-map', but it's ok to leave
`w3m-info-like-map' as they are, isn't it?

> 2] Terminology (sessions, buffers, tabs, windows)

> The project has an annoying inconsistency in how it refers to `things'.
> Emacs-w3m often uses the term 'session' to refer to an emacs buffer,
> what most browsers would call a 'tab'[1], but sometimes to refer to the
> collection of all buffers[2]. And although the project often refers to
> emacs buffers as 'sessions', it also refers to them as buffers[3].

> I'd like to propose that the project start changing documentation and
> user-prompts to be more consistent, and to acknowledge the duplication
> of terms. 'Sessions' should refer to the collection of all w3m 'buffers'
> (or 'tabs') open at a time.

> I'm raising the issue for this patch because it is a good example and
> starting point. The patch as submitted respects the current terminology,
> but I think it should be re-worded to replace session with either
> 'buffer' or 'tab'. My inclination is to favor 'buffer'.

I haven't ever been worrying so much about this issue, but have
no objection to reorganizing the terms.  Though using tabs is
the default, emacs-w3m supports browsing of many pages using
multiple frames or windows as well as tabs.  So, making the term
`session' and the like integrate to `buffer(s)' would be better,
I think.

> The elephant in the room would be the matter of re-factoring the
> code-base, which is do-able, and which can include defining aliases to
> old symbol names, for a deprecation period.

> Footnotes:
> ━━━━━━━━━━
> [1] e.g., w3m-goto-url-new-session, w3m-search-new-session,
>     w3m-bookmark-view-new-session.

> [2] e.g., the functions of file w3m-session.el.

> [3] e.g., w3m-next-buffer, w3m-previous-buffer, w3m-copy-buffer.