[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [BUGFIX] w3m-session-delete [PATCH]

On 2017-12-14 18:59, Katsumi Yamaoka wrote:
> In [emacs-w3m:12851]
> On Thu, 14 Dec 2017 18:48:51 +0900, Katsumi Yamaoka wrote:
> > Sorry, the above part in the bottom of the patch will cause
> > an error if all sessions are deleted.  Replace it with this:
> Ah, this causes another error.  I'll fix it tomorrow morning.
> Sorry for the noise.

No need to apologize to anyone who has read the code. This is a case
where we both fell victim to bad design. The code is written in lisp,
inherits lisp structures, but persists in performing its functions in
very un-lisp ways, going off in what I imagine is a very inefficient
manner searching incrementally in strings for the next occurrence of a
text property, when there is a very efficient lisp alternative of going
to the next or nth list element. I found it frustrating and
disheartening to read the code in this part of the project, especially
in view of how other parts of the project show a mastery of the power of

CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0