[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: this page rendering [PATCH]

On 2018-05-10 18:05, Filipp Gunbin wrote:
> On 09/05/2018 03:45 -0400, Boruch Baum wrote:
> > On 2018-05-09 00:46, andrés ramírez reported that non-breaking spaces were
> > being visually represented on rendered html pages, and that they shouldn't.
> > The attached patch fixes that by setting variable nobreak-char-display nil
> > as a local variable for all w3m mode buffers.
> >
> > An example page is:
> >
> >  https://cheryllium.wordpress.com/2014/04/13/commonqt-tutorial-4/
> I think the better solution would be to provide variable
> `w3m-nobreak-char-display', and bind `nobreak-char-display' to its value
> in w3m-mode buffers.

Flexibility always sounds good to me, so I don't object. I suggest the
default should be nil, since w3m buffers are for presentation, not
editing, so the visual cue can be distracting / annoying, which I guess
was why Andrés reported the issue in the first place.

> Or just to provide recipe in docs of how to bind `nobreak-char-display'
> in w3m-mode hook(s) properly.

Less user-friendly and economical - let one developer spend a few
minutes once in creation and save all future users the hassle of hunting
down the problem, finding the documentation, and making the change
correctly. In this particular case, my guess is that it would take less
time for a developer to code a fix than to write the documentation

@Katsumi-san: Use the current patch? Adopt Filipp's first suggestion
(I'll code it)?

CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0