[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [REFACTOR] w3m-process-queue memory and redability [PATCH]



In [emacs-w3m:12995]
On Tue, 29 May 2018 02:13:56 -0400, Boruch Baum wrote:
> Never mind. I've just tested on a clean install with the patch and the
> bugs don't happen, so it must be something else on my local development
> install - the refactor patch still looks good.

Well, the change is only to divide a function into two parts,
isn't it?  Even if it is worth doing, you should fix these
compiler warnings:

Compiling w3m.el...

In w3m--dump-extra--handler-function:
w3m.el:5542:15:Warning: reference to free variable ‘success’

In w3m--retrieve--handler-function:
w3m.el:5713:39:Warning: reference to free variable ‘attr’

In w3m--retrieve-1--handler-function:
w3m.el:5753:18:Warning: reference to free variable ‘attr’

In w3m--retrieve-and-render--handler-function:
w3m.el:6462:59:Warning: reference to free variable ‘type’

In w3m--goto-url--handler-function:
w3m.el:9713:14:Warning: reference to free variable ‘action’
w3m.el:9729:40:Warning: reference to free variable ‘orig’
w3m.el:9743:26:Warning: reference to free variable ‘history-position’

In w3m--goto-url--valid-url:
w3m.el:9877:22:Warning: reference to free variable ‘furl’