[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [REFACTOR] w3m-process-queue memory and redability [PATCH]

IIUC, these compiler warnings are complaining about scope issues that
aren't a real problem and don't seem to me possible to be 'fixed' - it's
the way the emacs-w3m code is designed with all the asynchronous
processing and handler functions. My plan is to conduct some tests just
to be certain, but I'm not sure I can get to it before the weekend, so
if it *IS* clear to you, let me know so you can save me the trouble of
the work. At this point, it seems to me that any problem related to
these warnings have always existed, but the warnings were masked because
the functions had been declared as lambdas in the caller.

Your thoughts?

On 2018-06-07 16:02, Katsumi Yamaoka wrote:
> In [emacs-w3m:12995]
> On Tue, 29 May 2018 02:13:56 -0400, Boruch Baum wrote:
> > Never mind. I've just tested on a clean install with the patch and the
> > bugs don't happen, so it must be something else on my local development
> > install - the refactor patch still looks good.
> Well, the change is only to divide a function into two parts,
> isn't it?  Even if it is worth doing, you should fix these
> compiler warnings:
> Compiling w3m.el...
> In w3m--dump-extra--handler-function:
> w3m.el:5542:15:Warning: reference to free variable ‘success’
> In w3m--retrieve--handler-function:
> w3m.el:5713:39:Warning: reference to free variable ‘attr’
> In w3m--retrieve-1--handler-function:
> w3m.el:5753:18:Warning: reference to free variable ‘attr’
> In w3m--retrieve-and-render--handler-function:
> w3m.el:6462:59:Warning: reference to free variable ‘type’
> In w3m--goto-url--handler-function:
> w3m.el:9713:14:Warning: reference to free variable ‘action’
> w3m.el:9729:40:Warning: reference to free variable ‘orig’
> w3m.el:9743:26:Warning: reference to free variable ‘history-position’
> In w3m--goto-url--valid-url:
> w3m.el:9877:22:Warning: reference to free variable ‘furl’

CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0