[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [REFACTOR] w3m-process-queue memory and redability [PATCH]

In [emacs-w3m:13011]
On Thu, 07 Jun 2018 18:41:27 -0400, Boruch Baum wrote:
> IIUC, these compiler warnings are complaining about scope issues that
> aren't a real problem and don't seem to me possible to be 'fixed'

Even if those compiler warnings are harmless and trivial, they
have a potential to hide a serious problem that might happen in
the future.  So, we've been keeping the zero warning policy.
It looks easy to me to suppress those warnings.  That is, to pass
those symbols with values from a function to another.  For the
asynchronous process we can use `lexical-let' (that might be
just what you want to eliminate, though).  Anyway, I don't want
to leave the emacs-w3m code to issue warnings arbitrarily.


> In w3m--goto-url--valid-url:
> w3m.el:9877:22:Warning: reference to free variable ‘furl’

What does set the value of `furl'?  If it is a typo, this is just
the fruit of the zero warning policy, isn't it?