[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [REFACTOR] w3m-process-queue memory and redability [PATCH v2]

PS messages received!

On 2018-06-12 14:42, Katsumi Yamaoka wrote:
> In [emacs-w3m:13013]
> On Fri, 08 Jun 2018 13:43:21 -0400, Boruch Baum wrote:
> > I did have some time, so I performed some tests and I was wrong; there
> > seems no harm passing the variables as arguments, so here's a revised
> > patch of the refactoring, that shouldn't generate any of those warnings.
> Applied.  Thanks.
> I only did verifying that the compiler issues no warning and
> trying running emacs-w3m with the patched w3m.elc roughly.
> P.S.
> If it's not too much trouble to you, could you set
> `indent-tabs-mode' to t in at least emacs-w3m's el files?
> Whereas it defaults to t globally, the .dir-locals.el file
> existing in the Emacs source tree sets it to nil for only
> the emacs-lisp mode nowadays, though.
> P.S.-2
> I'll be happy if you run `indent-region' on a Lisp function
> definition before posting it.  You may want to load cl, etc.,
> if the code uses them, in order to get the correct indentation.
> P.S.-3
> I'm using develock.el[1] that I wrote:
> ;; Develock is a minor mode which provides the ability to make font-
> ;; lock highlight leading and trailing whitespace, long lines and
> ;; oddities in the file buffer for Lisp modes, ChangeLog mode, ...
> [1] https://www.jpl.org/ftp/pub/elisp/develock.el.gz

CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0