[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
macros for w3m-attributes
- From: Boruch Baum <boruch_baum@xxxxxxx>
- Date: Fri, 31 Aug 2018 14:56:51 -0400
- X-ml-name: emacs-w3m
- X-mail-count: 13023
In the course of trying to debug an issue, I see a series of macros that
call function `w3m-attributes' and return a subset of that function's
output. What strikes me as unnecessary is that all of them perform a
check for a HANDLER argument - but that same identical check is done by
the underlying function `w3m-attributes' itself!
Am I missing some subtle issue in emacs / emacs-w3m process management?
It seems to me that the macros should all be simplified to the form
`(------ (w3m-attributes ,url ,no-cache))))
but I hesitate to push a patch because I may be missing something subtle.
Here is a list of the macros in question
All are of the form:
`(let ((handler ,handler))
(attrs (w3m-attributes ,url ,no-cache handler))
`(car (w3m-attributes ,url ,no-cache))))
Note that `w3m-process-do' is itself a macro, and that it will create a
local variable `attrs' bound to the output of `w3m-attributes'.
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0