[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [BUGREPORT] "saving-face"

On 2020-10-29 16:50, Katsumi Yamaoka wrote:
> In [emacs-w3m:13684]
> On Thu, 29 Oct 2020 03:29:26 -0400, Boruch Baum wrote:
> > I'm not totally sure about this, but I think I've come across several bugs in
> > function `w3m-remove-face-property' of file `w3m-util.el'.
> Your solution looks very correct.  I'm going to examine it by
> myself and install the fixed one.  Thank you for the advice.

Here's one improvement for resiliency. Change:

 (if (= 1 (length new-prop))


 (if (>= 1 (length new-prop))

This will catch what is *supposed* to be the impossible case of '(), ie.
at the entry to the function the face property was malformed as a single
item list and had its single element removed.

CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0