[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [PATCH] add `w3m-search-new-session'

Hello やまおか-san!

On Tue, 26 Sep 2006 03:09:08 +0200, Katsumi Yamaoka wrote:
>>>>>> In [emacs-w3m : No.08881] Luca Capello <luca@xxxxxx> wrote:
>> 2006-09-26  Luca Capello  <luca@xxxxxx>
> Done.

Thank you :-)

> Thank you for the patch.  It looks mostly perfect, moreover it
> makes the source code clean.  I've installed it with slight
> modifications.  My changes are:
> -(defun w3m-search-read-variables (search-engine query)
> -  "Ask for SEARCH-ENGINE and QUERY if empty and return them as a list."
> +(defun w3m-search-read-variables ()
> +  "Ask for a search engine and words to query and return them as a list."
> -  (interactive
> -   (let ((search-engine) (query))
> -     (w3m-search-read-variables search-engine query)))
> +  (interactive (w3m-search-read-variables))
>    (w3m-search-do-search 'w3m-goto-url search-engine query))

It's clearly a better solution: I should say that I tried something
similar, but I never got it working.

Anyway, I'm glad you appreciated my patch.

Thx, bye,
Gismo / ルカ

Attachment: pgp07h3T4keyB.pgp
Description: PGP signature