[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] w3m-lnum add highlight
- From: Katsumi Yamaoka <yamaoka@xxxxxxx>
- Date: Thu, 08 Sep 2011 08:15:52 +0900
- X-ml-name: emacs-w3m
- X-mail-count: 11644
- References: <b4mpqz1s2fg.fsf@xxxxxxx> <87k4p88gbq.fsf@xxxxxxxxx> <b4meifggiel.fsf@xxxxxxx> <878w5nv8fn.fsf@xxxxxxxxx> <b4m1vbeflye.fsf@xxxxxxx> <20100708.200709.142440111.1BF46D@xxxxxxxxxxx> <b4mwrt689f2.fsf@xxxxxxx> <87d3uxix4z.fsf@xxxxxxxxx> <b4mmxu1chti.fsf@xxxxxxx> <87zkxzbbzz.fsf@xxxxxxxxx> <b4m39vp2mkw.fsf@xxxxxxx> <87hbk3ppib.fsf@xxxxxxxxx> <b4moceak9v3.fsf@xxxxxxx> <87mxtasc90.fsf@xxxxxxxxx> <b4meiemcuja.fsf@xxxxxxx> <87eid76kds.fsf@xxxxxxxxx> <b4mtym2zbv9.fsf@xxxxxxx> <87r5gi9owm.fsf@xxxxxxxxx> <b4mbp7keygd.fsf@xxxxxxx> <87k49o8ru3.fsf@xxxxxxxxx> <b4maaajhnm0.fsf@xxxxxxx> <87zkigf3wp.fsf@xxxxxxxxx>
In [emacs-w3m : No.11643] Andrey Kotlarski wrote:
> thank you for making it work under other Emacsen as well. Your changes
> made me realise there are some other places that need this overlay start
> workaround. I also sneaked in a few optimisations and... Naming seems a
> bit inconsistent and propose to radically put it in order by replacing
> `w3m-linknum' and `w3m-link-numbering' prefixes with `w3m-lnum'.
> Removed `w3m-go-to-linknum' (now `w3m-lnum-goto') from `C-c C-l' as it
> is under `L F' anyway. Obviously these changes will break existing use
> (in code) of these functions but if there are any other users of this
> sub-mode, I expect them not to have any problem ;) Also a few not that
> specific functions and macros may go to w3m-util.el. Here's the
> proposed diff:
I realized overlay end value has to be fixed too, as (window-end)
returns (1+ (point-max)) in XEmacs if contents end within a window.
I've committed your patch along with it. Thanks.