[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [PATCH] w3m-lnum add highlight

In [emacs-w3m : No.11643] Andrey Kotlarski wrote:
> thank you for making it work under other Emacsen as well.  Your changes
> made me realise there are some other places that need this overlay start
> workaround.  I also sneaked in a few optimisations and... Naming seems a
> bit inconsistent and propose to radically put it in order by replacing
> `w3m-linknum' and `w3m-link-numbering' prefixes with `w3m-lnum'.
> Removed `w3m-go-to-linknum' (now `w3m-lnum-goto') from `C-c C-l' as it
> is under `L F' anyway.  Obviously these changes will break existing use
> (in code) of these functions but if there are any other users of this
> sub-mode, I expect them not to have any problem ;) Also a few not that
> specific functions and macros may go to w3m-util.el.  Here's the
> proposed diff:

I realized overlay end value has to be fixed too, as (window-end)
returns (1+ (point-max)) in XEmacs if contents end within a window.
I've committed your patch along with it.  Thanks.