Re: [PATCH] Add functionality for editing textareas in Org-mode

[Thorsten Jolitz <tjolitz@xxxxxxxxx>]

Katsumi Yamaoka <yamaoka@xxxxxxx> writes:

> In [emacs-w3m : No.12163] Thorsten Jolitz wrote:
>>> Anyway you must try running at least `./configure; make install'
>>> before posting patches.
>
>> mmhh, did not work somehow, but starting emacs-w3m and then loading
>> modified w3m-form.el again had me edit textareas in an Org-mode edit
>> buffer without problems, so I hope it works now.
>
> `make' runs Emacs without loading user's customization, auxiliary
> program, or third-party program.  Though no error or no warning
> doesn't necessarily guarantee a code is complete, it sometimes
> offers useful informations.  For instance:
>
> ,---- (Emacs 24.3.50)
> | In end of data:
> | w3m-form.el:2001:1:Warning: the function `show-all' is not known to be
> |     defined.
> | Wrote /Work/emacs-w3m/w3m-form.elc
> `----
>
> I guess the `show-all' function is that of outline.el, but Org-mode
> doesn't seem to load it explicitly.  So, we may want to add autoload
> or other for it (even if it is only for silencing the byte compiler).

yes, Org-mode derives from outline.el and uses this parent-mode
function. please go ahead and add an autoload statement.

> ,---- (XEmacs 21.4.22)
> | Compiling /Work/emacs-w3m/w3m-form.el...
> | While compiling w3m-form-input-textarea-mode-setup in file
> |     /Work/emacs-w3m/w3m-form.el:
> |   ** reference to free variable view-mode
> | While compiling the end of the data:
> |   ** The following functions are not known to be defined:  show-all,
> |     split-window-sensibly
> | Wrote /Work/emacs-w3m/w3m-form.elc
> `----
>
> The first one (view-mode) is due to my fault, has already been
> fixed.  (I wonder why the old code was working...)
>
> According to Emacs' ChangeLog files, `split-window-sensibly' was
> introduced in 2009-05-07, so it will be available in only Emacs
> 23 (July, 2009) and up.  But not in XEmacsen.  It means that we
> have to put the lid on it for people who use such old (X)Emacsen
> if `split-window-sensibly' is essential.  Is it allowed to do
> like this?
>
> (if (and w3m-form-textarea-use-org-mode-p
>          (foundp 'split-window-sensibly))
>     (split-window-sensibly cur-win)
>   (split-window cur-win (if (> size 0) size window-min-height)))

Thats perfectly ok, since recent version 8.0 of Org-mode introduced the
new parser and exporter framework, and anybody with older versions is
really decoupled from actual Org-mode development. And I can't imagine
somebody running Org-mode 8+ on such old Emacs versions. 

-- 
cheers,
Thorsten