[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: [PATCH] RT reply form submission (Emacs-w3m bug)



Hello Katsumi!

Em Wed, 14 Oct 2015 08:30:37 +0900
Katsumi Yamaoka <yamaoka@xxxxxxx> escreveu:

> Ok, I've installed the change.

Thank you! :-)


> As far as I see the benchmark[1] tests, the encode-coding-string
> funcall seems to take more time even if it does nothing:
> 
> (let ((buf '(nil . nil)) (coding 'utf-8))
>   (benchmark 1000000
> 	     (encode-coding-string (if (cdr buf) (cdr buf) "")
> coding))) 0.7090411186218262
> 0.7090411186218262
> 0.7220408916473389
> 
> (let ((buf '(nil . nil)) (coding 'utf-8))
>   (benchmark 10000000
> 	     (if (cdr buf) (encode-coding-string  (cdr buf) coding)
> ""))) 0.41602396965026855
> 0.4350249767303467
> 0.42002391815185547
> 
> Probably such a large repetition will not take place, though. ;-)

Is it intentional that you made your version iterate an order of
magnitude more times than mine?  In any case, that only strengthens your
point.  I wasn't concerned about performance, though --- just
correctness. ;-)


-- 
 88888  FFFFF Bruno FĂ©lix Rezende Ribeiro (oitofelix) [0x28D618AF]
 8   8  F     http://oitofelix.freeshell.org/
 88888  FFFF  mailto:oitofelix@xxxxxxx
 8   8  F     irc://chat.freenode.org/oitofelix
 88888  F     xmpp://oitofelix@xxxxxxxxxx

- GNU ccd2cue maintainer
- GNU Savannah hacker
- GNU webmaster
- GNU web translation team coordinator (Brazilian Portuguese)
- GNU audio and video maintainer
- DMOZ free software editor (Portuguese)
- UFU FAMAT PET member
- SDF Public Access UNIX System ARPA member
- Riseup user and supporter

Please, support my work: http://oitofelix.freeshell.org/funding.html

[GNU DISCLAIMER] I'm a GNU hacker, but my views don't necessarily
match those of the GNU project.  Hereby I express my own opinion,
style and perception, in good faith, aiming the betterment of GNU.

Attachment: pgp3DZJzh1ycv.pgp
Description: Assinatura digital OpenPGP