[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Form reuse doesn't update content [PATCH]
On Wed, 04 Apr 2018 02:02:11 -0400, Boruch Baum wrote:
> 1] Go to a page on emacswiki, say
> 2] Perform an edit, such as inserting a test message, or a single
> unobtrusive symbol that no-one would notice, and save the edit.
> 3] Navigate away from the page. Maybe visit the the page you just edited
> just to be sure that the edit tookhold.
> 4] Navigate back to the page.
> 5] The textarea content of the edit box does not include your (my)
> recent edit. Rather, it remains the same as when you (I) first visited
> the page.
Thanks. I realized how the problem is serious, and your fix
(304 check) seems a good approach. I've committed your patch
excluding your (message "Boruch:...") probes and:
On Tue, 03 Apr 2018 17:00:46 -0400, Boruch Baum wrote:
> --- w3m.el 27 Feb 2018 06:23:35 -0000 1.1706
> +++ w3m.el 3 Apr 2018 20:26:28 -0000
> - (when (eq (car w3m-current-forms) t)
> - (setq w3m-current-forms (cdr w3m-current-forms)))
> +; (when (eq (car w3m-current-forms) t)
> +; (setq w3m-current-forms (cdr w3m-current-forms)))
This is still necessary even if the way is not so smart. See
the function `w3m-fontify-forms' (w3m-form.el) and how the
function `w3m-goto-url' (w3m.el) pushes the `t' flag.