[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: w3m-url-valid
On 2017-07-19 15:23, Katsumi Yamaoka wrote:
> In [emacs-w3m : No.12758]
> On Wed, 19 Jul 2017 00:28:05 +0900, TSUCHIYA-san wrote:
> > This change was introduced as the result of the discussion of
> > "[emacs-w3m:04095] cookie-get error at text/html part".
>
> <http://emacs-w3m.namazu.org/ml/msg03998.html>
>
> > Especially, its meaning was described at "[emacs-w3m:04101] Re:
> > cookie-get error at text/html part".
>
> <http://emacs-w3m.namazu.org/ml/msg04004.html>
>
> I understood what (defconst w3m-url-fallback-base "http:///";)
> does really mean and is used for after all.
>
> > Then, I conclude as follows:
>
> > (1) `w3m-url-fallback-base' is considered as two meanings. The first
> > meaning is described at [emacs-w3m:12757], and the second meaning is the
> > impossible value of the URI string described at [emacs-w3m:04101].
>
> > (2) And, w3m-url-valid() is not considered as a generic validation
> > function. It was simply designed as an ad-hoc function to avoid
> > handling errors of URIs for the cases when no base URI is given.
>
> I got it; a url beginning with "http:///"; is generated internally
> in emacs-w3m for a certain situation in order to be rejected as
> an invalid url thereafter.
1] If I am correctly understanding the discussion and conclusion, how
about renaming `w3m-url-fallback-base' to `w3m-invalid-base', to make
it consistent with `w3m-url-invalid-regexp' and to be more descriptive?
2] Also, I have been providing patches using the normal command-line
`diff'. Is it acceptable to provide them using the output of `cvs diff'?
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
--- w3m.el 2017-07-20 07:43:24.116886896 -0400
+++ w3m.el-new 2017-07-20 07:43:15.420958065 -0400
@@ -6968,7 +6968,7 @@
(error "BASE must have a scheme part: %s" base))
(setq base (or w3m-current-base-url
w3m-current-url
- w3m-url-fallback-base)))
+ w3m-url-invalid-base)))
(w3m-string-match-url-components url)
;; Remove an empty fragment part.
(when (and (match-beginning 8)
--- ChangeLogold 2017-07-20 07:48:55.522862432 -0400
+++ ChangeLog 2017-07-20 07:55:22.038008462 -0400
@@ -1,3 +1,8 @@
+2017-07-20 <optimum@xxxxxxxxxxxxxxxxxxxx>
+
+ * w3m.el, w3m-util.el (w3m-url-fallback-base): Rename `w3m-url-fallback-base'
+ to more descriptive `w3m-invalid-base'
+
2017-07-16 Boruch Baum <boruch_baum@xxxxxxx>
* w3m.el (w3m-canonicalize-url): Make scheme default to https, not http.
--- w3m-util.el 2017-07-20 07:46:48.171487233 -0400
+++ w3m-util.el-new 2017-07-20 07:46:40.427531195 -0400
@@ -803,7 +803,7 @@
;;; Miscellaneous:
-(defconst w3m-url-fallback-base "http:///";)
+(defconst w3m-url-invalid-base "http:///";)
(defconst w3m-url-invalid-regexp "\\`http:///";)
(defmacro w3m-substitute-key-definitions (new-map old-map &rest keys)