[Date Prev][Date Next][Thread Prev][][Date Index][Thread Index]

Re: Patch for bug in w3m-generate-new-buffer

In [emacs-w3m:12927]
On Fri, 23 Feb 2018 11:33:42 -0800, Vladimir Sedach wrote:
>> --- w3m-util.el~	2018-02-05 01:24:42.346587300 +0000
>> +++ w3m-util.el	2018-02-15 07:49:52.626357200 +0000
[...my change...]

> This change does not fix anything, it just seems to make it never
> execute the PROGN clause in lines 464-473. All new tabs go to the end.
> The buggy code in lines 464-473 just sits there and does nothing.

The PROGN section will be traced when `M-x w3m-copy-buffer' runs.
Apart from it, I could find no different behavior between mine and
yours except that `w3m-view-this-url-1' passes t to the 3rd arg
of `w3m-generate-new-buffer' and your code is much smarter. :-)

> Can you please apply my patch?

I've installed your patch with a slight modification, and I'm
going to be trying it anyway.

In addition to this, I've removed the `w3m-parent-session-buffer'
variable temporarily.  Maybe it should revive as like:

,---- w3m-previous-session-buffer
| A buffer of the session having selected just before this session.
| This will be the session to be selected after `w3m-delete-buffer'
| deletes the current session.

(I tried it but gave up for now.)